On Tue, Mar 20, 2018 at 10:01:24AM +0000, Peter Maydell wrote: > On 20 March 2018 at 09:44, Daniel P. Berrangé <berra...@redhat.com> wrote: > > We can follow what autoconf does, and add a check to configure to see if > > there are generated files left in the source dir, when configuring with > > builddir != srcdir, and exit with error, telling user to clean their > > src dir first. > > We already do this in our makefile...it just doesn't check every > single generated file.
Ah yes, indeed: $ make Makefile:59: *** This is an out of tree build but your source tree (/home/berrange/src/virt/qemu) seems to have been used for an in-tree build. You can fix this by running "make distclean && rm -rf *-linux-user *-softmmu" in your source tree. Stop. It is checking for existance of config-host.mak. We have a convenient list of generated files in $(GENERATED_FILES), so I wonder if there's a practical way to check all of those too. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel