On 05.07.2021 19:47, Paul Durrant wrote: > On 05/07/2021 17:06, Jan Beulich wrote: >> p2m_add_page() is simply a rename from guest_physmap_add_entry(). >> p2m_remove_page() then is its counterpart, despite rendering >> guest_physmap_remove_page(). > > Did some words get dropped in that second sentence? I can't really > understand what it is saying.
Oops - this was meant to be "... a trivial wrapper". >> This way callers can use suitable pairs of >> functions (previously violated by hvm/grant_table.c). >> >> In HVM-specific code further avoid going through the guest_physmap_*() >> layer, and instead use the two new/renamed functions directly. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> > > The code looks fine so... > > Reviewed-by: Paul Durrant <p...@xen.org> Thanks. Jan