On 21.07.2021 05:07, Penny Zheng wrote: >> -----Original Message----- >> From: Jan Beulich <jbeul...@suse.com> >> Sent: Monday, July 19, 2021 4:20 PM >> To: Penny Zheng <penny.zh...@arm.com> >> Cc: Bertrand Marquis <bertrand.marq...@arm.com>; Wei Chen >> <wei.c...@arm.com>; nd <n...@arm.com>; xen-devel@lists.xenproject.org; >> sstabell...@kernel.org; jul...@xen.org >> Subject: Re: [PATCH V3 05/10] xen/arm: static memory initialization >> >> On 15.07.2021 07:18, Penny Zheng wrote: >>> v3 change: >>> - include addition of CONFIG_STATIC_ALLOCATION in this commit, where >>> it is firstly used and also change the name to CONFIG_STATIC_MEMORY >>> - Fix TAB typo in Kconfig >> >> Not sure what this relates to, but ... >> > > Before I was wrongly using " set tabstop=4 " for Kconfig file, so... > >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -106,6 +106,9 @@ config TEE >>> >>> source "arch/arm/tee/Kconfig" >>> >>> +config STATIC_MEMORY >>> + def_bool y >> >> ... this is (wrongly) using spaces for indentation. >> >> I also wonder about the placement: Shouldn't the option live in common code, >> with Arm "select"ing it? >> > > Sure, I will place it in xen/common/Kconfig, and add "depends on ARM".
But I didn't say to use "depends on", but "select". "depends on" would be appropriate to use if the option had a prompt (i.e. if one could also disable it on Arm). Jan
