Hi Andre,
On 03/21/2018 04:32 PM, Andre Przywara wrote:
diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c
index 131358a5a1..22c70ff7cd 100644
--- a/xen/arch/arm/vgic/vgic.c
+++ b/xen/arch/arm/vgic/vgic.c
@@ -981,6 +981,16 @@ unsigned int vgic_max_vcpus(const struct domain *d)
return min_t(unsigned int, MAX_VIRT_CPUS, vgic_vcpu_limit);
}
+#ifdef CONFIG_HAS_GICV3
+void vgic_v3_setup_hw(paddr_t dbase,
+ unsigned int nr_rdist_regions,
+ const struct rdist_region *regions,
+ unsigned int intid_bits)
+{
+ /* Dummy implementation to allow building without actual vGICv3 support. */
One major inconvenience with that solution is GICv3 driver is going to
be initialized but then you hit the BUG_ON() in domain_vgic_register.
This is really not nice for the user but it is not obvious why the
BUG_ON() is hit.
I am ok if you don't want to touch the Kconfig. But I would at least
implement that helper with a panic("vGICv3 not yet supported with the
new vGIC");
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel