On 20.09.21 12:57, Ian Jackson wrote:
Roger Pau Monné writes ("Re: [PATCH 4/6] tools/xenstored: use atexit to close interfaces"):On Mon, Sep 20, 2021 at 11:22:15AM +0200, Juergen Gross wrote:Could you please add closing of xce_handle(), too?Sure, I somehow assumed there was a reason for not closing it related to live update, but I see that's not the case as you use exec to launch the new image and atexit handlers are not called in that case.Are these fds marked CLOEXEC ? I don't think they are BICBW.
They are. I checked when implementing LU and just rechecked. The event-channel fd is opened explicitly without CLOEXEC in order to support LU (the new xenstored won't open it again, but gets its fd via the migration stream). Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
