On 24.09.2021 06:34, Wei Chen wrote: >> From: Stefano Stabellini <sstabell...@kernel.org> >> Sent: 2021年9月24日 9:15 >> >> On Thu, 23 Sep 2021, Wei Chen wrote: >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -11,6 +11,16 @@ config COMPAT >>> config CORE_PARKING >>> bool >>> >>> +config EFI >>> + bool >> >> Without the title the option is not user-selectable (or de-selectable). >> So the help message below can never be seen. >> >> Either add a title, e.g.: >> >> bool "EFI support" >> >> Or fully make the option a silent option by removing the help text. > > OK, in current Xen code, EFI is unconditionally compiled. Before > we change related code, I prefer to remove the help text.
But that's not true: At least on x86 EFI gets compiled depending on tool chain capabilities. Ultimately we may indeed want a user selectable option here, but until then I'm afraid having this option at all may be misleading on x86. Jan
