On 13.10.2021 12:57, Anthony PERARD wrote: > On Mon, Oct 11, 2021 at 02:39:26PM +0200, Jan Beulich wrote: >> On 24.08.2021 12:50, Anthony PERARD wrote: >>> @@ -222,14 +222,14 @@ $(TARGET).efi: FORCE >>> endif >>> >>> # These should already have been rebuilt when building the prerequisite of >>> "prelink.o" >>> -efi/buildid.o efi/relocs-dummy.o: ; >>> +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ; >>> >>> .PHONY: include >>> include: $(BASEDIR)/arch/x86/include/asm/asm-macros.h >>> >>> -asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P >>> +$(obj)/asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P >>> >>> -$(BASEDIR)/arch/x86/include/asm/asm-macros.h: asm-macros.i Makefile >>> +$(BASEDIR)/arch/x86/include/asm/asm-macros.h: $(obj)/asm-macros.i >>> $(src)/Makefile >> >> Isn't this $(obj)/include/asm/asm-macros.h ? And in general doesn't >> use of $(BASEDIR) need to go away then, e.g. ... > > I've limited this patch to add $(obj)/ and $(src)/ were needed, I think. > > And yes, BASEDIR will need to go away.
And replacing it here while you're touching the line anyway is not an option? >>> --- a/xen/scripts/Makefile.clean >>> +++ b/xen/scripts/Makefile.clean >>> @@ -3,11 +3,14 @@ >>> # Cleaning up >>> # >>> ========================================================================== >>> >>> +obj := . >>> +src := $(obj) >> >> This repeats what is also getting added to Rules.mk. To prevent >> the two going out of sync, wouldn't they better live in a central >> place (e.g. scripts/defs.mk)? > > It looks like they are the same but they are not, it doesn't matter if > they go out of sync, and they actually do in my patch series. How can them going out of sync be correct? Jan
