On Fri, 22 Oct 2021, Anthony PERARD wrote: > On Thu, Oct 21, 2021 at 04:08:38PM -0700, Stefano Stabellini wrote: > > diff --git a/automation/tests-artifacts/kernel/5.10.74.dockerfile > > b/automation/tests-artifacts/kernel/5.10.74.dockerfile > > new file mode 100644 > > index 0000000000..f2dbbecf74 > > --- /dev/null > > +++ b/automation/tests-artifacts/kernel/5.10.74.dockerfile > > @@ -0,0 +1,38 @@ > > +FROM debian:unstable > > +LABEL maintainer.name="The Xen Project" \ > > + maintainer.email="xen-devel@lists.xenproject.org" > > + > > +ENV DEBIAN_FRONTEND=noninteractive > > +ENV LINUX_VERSION=5.10.74 > > +ENV USER root > > + > > +RUN mkdir /build > > +WORKDIR /build > > + > > +# build depends > > +RUN apt-get update && \ > > + apt-get --quiet --yes install \ > > + build-essential \ > > + libssl-dev \ > > + bc \ > > + curl \ > > + flex \ > > + bison \ > > + libelf-dev \ > > + && \ > > + \ > > + # Build the kernel > > You could start a new docker "RUN" step to build the kernel.
OK > > + curl -fsSLO > > https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz > > && \ > > + tar xvJf linux-"$LINUX_VERSION".tar.xz && \ > > + cd linux-"$LINUX_VERSION" && \ > > + make defconfig && \ > > + make xen.config && \ > > + cp .config .config.orig && \ > > + cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config && \ > > This command line could be replaced by: > sed -i '/XEN/s/=m$/=y/' .config > But I guess Kconfig don't mind duplicated symbols. Yeah the latter overwrites the former > > + make -j$(nproc) bzImage && \ > > + cp arch/x86/boot/bzImage / && \ > > + cd /build && \ > > + rm -rf linux-"$LINUX_VERSION"* && \ > > > > + apt-get autoremove -y && \ > > + apt-get clean && \ > > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > > This apt cleaning stuff should be done right after `apt install`, and > thus before starting to build the kernel, I think. OK > Any any case: > Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> Thanks Anthony!
