On Fri, Nov 05, 2021 at 01:34:12PM +0100, Jan Beulich wrote:
> The hook functions have been empty forever (x2APIC) or issuing merely a
> printk() for a long time (xAPIC). Since that printk() is (a) generally
> useful (i.e. also in the x2APIC case) and (b) would better only be
> issued once the final APIC driver to use was determined, move (and
> generalize) it into connect_bsp_APIC().
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Roger Pau Monné <roger....@citrix.com>
> ---
> v2: New.
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -674,9 +674,7 @@ static void __init acpi_process_madt(voi
> error = acpi_parse_madt_ioapic_entries();
> if (!error) {
> acpi_ioapic = true;
> -
> smp_found_config = true;
> - clustered_apic_check();
> }
> }
> if (error == -EINVAL) {
> --- a/xen/arch/x86/apic.c
> +++ b/xen/arch/x86/apic.c
> @@ -243,6 +243,12 @@ void __init connect_bsp_APIC(void)
> outb(0x70, 0x22);
> outb(0x01, 0x23);
> }
> +
> + printk("Enabling APIC mode: %s. Using %d I/O APICs\n",
I don't think it makes sense to prefix APIC with 'x' or 'x2' here, as
we already print the APIC mode elsewhere?
> + !INT_DEST_MODE ? "Physical"
> + : init_apic_ldr == init_apic_ldr_flat ? "Flat"
> + :
> "Clustered",
> + nr_ioapics);
> enable_apic_mode();
This also seem to be completely unneeded? I guess it would be cleaned
in a further patch.
Thanks, Roger.
