On 18.11.2021 00:20, Andrew Cooper wrote:
> On 17/11/2021 23:14, Andrew Cooper wrote:
>> On 08/11/2021 09:50, Jan Beulich wrote:
>>> On 05.11.2021 14:55, Andrew Cooper wrote:
>>>> --- a/xen/xsm/flask/flask_op.c
>>>> +++ b/xen/xsm/flask/flask_op.c
>>>> @@ -22,6 +22,8 @@
>>>> #include <objsec.h>
>>>> #include <conditional.h>
>>>> +#include "../private.h"
>>> Kind of odd: I'd expect a file named such to not get included
>>> across directory levels, unless a single component was split in
>>> such a way (to me Flask and XSM core are separate, yet still
>>> related components).
>>
>> Its all a tangled mess because logically separating XSM and Flask was
>> a task done when SILO was introduced.
>>
>> There is not an appropriately located file (under xen/xsm/ ) where the
>> prototypes could reasonably live, and this felt like the lesser of the
>> available evils.
>
> I guess it is worth adding, so we're all on the same page.
>
> The thing I actually need to do is fix the fact that the prototypes for
> {do,compat}_flask_op() are local in xen/xsm/flask/hooks.c and not in a
> header shared with xen/xsm/flask/flask_op.c.
And I fully agree we need to do so. Me saying "kind of odd" also wasn't
meant as an objection, just to express my surprise to see something like
this.
Jan
