On 01.12.2021 10:33, Julien Grall wrote: > On 30/11/2021 18:12, Ayan Kumar Halder wrote: >> --- a/xen/include/xen/bitops.h >> +++ b/xen/include/xen/bitops.h >> @@ -5,7 +5,7 @@ >> /* >> * Create a contiguous bitmask starting at bit position @l and ending at >> * position @h. For example >> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000. >> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000. > > ... there are two extra changes here: > 1) The bitmask is now described with 8-characters (rather than 9) > 2) 'vector' is replaced with 'value' > > The former makes sense to me, but it is not clear to me why the latter > should be changed.
Would you mind explaining to me in which way you see "vector" accurately describe the entity talked about? I also think the commit message is quite fine as is. Jan
