> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 29 March 2018 13:29 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Julien Grall <julien.gr...@arm.com>; Andrew Cooper > <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Wei Liu > <wei.l...@citrix.com>; StefanoStabellini <sstabell...@kernel.org>; xen- > de...@lists.xenproject.org; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; Tim (Xen.org) <t...@xen.org> > Subject: RE: [PATCH v18 05/11] x86/mm: add HYPERVISOR_memory_op to > acquire guest resources > > >>> On 29.03.18 at 11:53, <paul.durr...@citrix.com> wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] > >> Sent: 26 March 2018 12:41 > >> > >> >>> On 22.03.18 at 12:55, <paul.durr...@citrix.com> wrote: > >> > --- a/xen/include/xlat.lst > >> > +++ b/xen/include/xlat.lst > >> > @@ -86,6 +86,7 @@ > >> > ! memory_map memory.h > >> > ! memory_reservation memory.h > >> > ! mem_access_op memory.h > >> > +! mem_acquire_resource memory.h > >> > >> Why ! ? The layout doesn't appear to differ between native and > >> compat. Or wait, the handle does, but why is that not > >> XEN_GUEST_HANDLE_64()? (I've skipped the compat layer code > >> in this round of review for that reason.) > > > > It's been XEN_GUEST_HANDLE throughout all but the earliest revisions of > the > > patch and I have not modified the compat code massively since you gave > your > > R-b anyway... the only thing that changed was copying back the new flags > > value. > > Granted I could/should have noticed this earlier, but being able to > get away without compat translation would certainly be a win, and > we have that option since this is a tools-only interface. >
Ok. I'll see if I can get this done today then. Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
