Hi Andrew,
Andrew Cooper <andrew.coop...@citrix.com> writes:
> There are two problems, both in the all_sources definition.
As a cscope user I want to thank you for the fix.
>
> First, everything in arch/*/include gets double hits with cscope queries,
> because they end up getting listed twice in cscope.files.
>
> Drop the first `find` rune of the three, because it's redundant with the third
> rune following c/s 725381a5eab3 ("xen: move include/asm-* to
> arch/*/include/asm").
>
> Second, and this way for a long time:
>
> $ make cscope
> ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
> find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
> cscope.files
> cscope -k -b -q
> cscope: cannot find file arch/x86/efi/efi.h
> cscope: cannot find file arch/x86/efi/ebmalloc.c
> cscope: cannot find file arch/x86/efi/compat.c
> cscope: cannot find file arch/x86/efi/pe.c
> cscope: cannot find file arch/x86/efi/boot.c
> cscope: cannot find file arch/x86/efi/runtime.c
>
> This is caused by these being symlinks to common/efi. Restrict all find runes
> to `-type f` to skip symlinks, because common/efi/*.c are already listed.
>
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babc...@epam.com>
> ---
> CC: Anthony PERARD <anthony.per...@citrix.com>
> CC: Jan Beulich <jbeul...@suse.com>
> CC: Roger Pau Monné <roger....@citrix.com>
> CC: Wei Liu <w...@xen.org>
> CC: Stefano Stabellini <sstabell...@kernel.org>
> CC: Julien Grall <jul...@xen.org>
> CC: Volodymyr Babchuk <volodymyr_babc...@epam.com>
> CC: Bertrand Marquis <bertrand.marq...@arm.com>
>
> Anthony: I looked through the remainder of your build series and I cant spot
> any edits to all_sources. Apologies if I missed it.
> ---
> xen/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/xen/Makefile b/xen/Makefile
> index 2ad7da7ad67b..dc6bdc44c7a2 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -468,9 +468,8 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h:
> asm-offsets.s
>
> SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
> define all_sources
> - ( find arch/$(TARGET_ARCH)/include -name '*.h' -print; \
> - find include -name '*.h' -print; \
> - find $(SUBDIRS) -name '*.[chS]' -print )
> + ( find include -type f -name '*.h' -print; \
> + find $(SUBDIRS) -type f -name '*.[chS]' -print )
In my tooling I'm using -printf "\"%p\"\n" because generally there might
be files with funny names.
> endef
>
> define set_exuberant_flags
--
Volodymyr Babchuk at EPAM
