On Tue, Jan 18, 2022 at 09:55:45AM +0000, Anthony PERARD wrote: > On Mon, Jan 17, 2022 at 10:48:16AM +0100, Roger Pau Monne wrote: > > Do this before adding any more stuff to xg_cpuid_x86.c. > > > > The placement in xenctrl.h is wrong, as they are implemented by the > > xenguest library. Note that xg_cpuid_x86.c needs to include > > xg_private.h, and in turn also fix xg_private.h to include > > xc_bitops.h. The bitops definition of BITS_PER_LONG needs to be > > changed to not be an expression, so that xxhash.h can use it in a > > preprocessor if directive. > > > > As a result also modify xen-cpuid and the ocaml stubs to include > > xenguest.h. > > Adding xenguest.h to ocaml stub has been done so it isn't part of this > patch anymore ;-).
I assume it was removed on rebase and I didn't even realize. > > Reported-by: Andrew Cooper <andrew.coop...@citrix.com> > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > > Acked-by: Anthony PERARD <anthony.per...@citrix.com> Thanks.
