Hi,
On 13/01/2022 22:53, Stefano Stabellini wrote:
+ kinfo->mem.nr_banks = nr_banks;
+
+ /*
+ * The property 'memory' should match the amount of memory given to
+ * the guest.
+ * Currently, it is only possible to either acquire static memory or
+ * let Xen allocate. *Mixing* is not supported.
+ */
+ if ( kinfo->unassigned_mem != 0 )
+ {
+ printk(XENLOG_ERR
+ "Size of \"memory\" property doesn't match up with the sum-up of
\"xen,static-mem\". Unsupported configuration.\n");
This line would benefit from being broken down, but I am also OK if we
leave it as is
We usually keep the message in a single line because (even if it is more
than 80 characters) because it helps to find the line afterwards.
Looking at the message, I would drop "Unsupported configuration" because
it implies that this is because some code is missing (IOW it will be
supported in the future). However, this is a requirement.
Cheers,
--
Julien Grall