On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote: > On 25.01.2022 12:00, Anthony PERARD wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -285,6 +285,16 @@ CFLAGS += -flto > > LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so > > endif > > > > +# Note that link order matters! > > Merely as a remark: I wonder how applicable that comment is anymore. > If anything I'd expect it to be relevant to $(TARGET_SUBARCH)/head.o > (Arm) and boot/built_in.o (x86), neither of which get named here.
Indeed, the order here probably doesn't matter. I tried to build on x86 with the list reversed (so still leaving boot/ first) and the build works. I didn't try to boot it. Maybe it's time to retire the comment? > > @@ -407,7 +417,7 @@ $(TARGET): FORCE > > $(MAKE) -f $(BASEDIR)/Rules.mk -C include > > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include > > $(MAKE) -f $(BASEDIR)/Rules.mk > > arch/$(TARGET_ARCH)/include/asm/asm-offsets.h > > - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) > > MKRELOC=$(MKRELOC) $@ > > + $(MAKE) -f $(BASEDIR)/Rules.mk MKRELOC=$(MKRELOC) > > "ALL_OBJS=$(ALL_OBJS-y)" "ALL_LIBS=$(ALL_LIBS-y)" $@ > > I'm always a little wary of using double quotes when it's not clear > what exactly a macro may expand to. Single quotes at least have less > restrictions ... Using single quotes sounds good. Thanks, -- Anthony PERARD