On Thu, Jan 27, 2022 at 04:01:32PM +0000, Jane Malalane wrote: > Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and > XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic > and x2apic, on x86 hardware. > No such features are currently implemented on AMD hardware. > > For that purpose, also add an arch-specific "capabilities" parameter > to struct xen_sysctl_physinfo. > > Signed-off-by: Jane Malalane <jane.malal...@citrix.com> > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > tools/golang/xenlight/helpers.gen.go | 4 ++++ > tools/golang/xenlight/types.gen.go | 6 ++++++
Note for committers: Please regenerate the go bindings, there are out-of-sync with libxl_types.idl at the moment. > diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c > index 1feadebb18..33da51fe89 100644 > --- a/tools/libs/light/libxl_x86.c > +++ b/tools/libs/light/libxl_x86.c > @@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc > *gc, > return rc; > } > > +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, > + xc_physinfo_t xcphysinfo) It might be better to pass "xcphysinfo" as a pointer, otherwise I think a copy of the whole struct is made when calling this function. In any case, the tool part of the patch looks good: Acked-by: Anthony PERARD <anthony.per...@citrix.com> Thanks, -- Anthony PERARD
