On 09/02/2022 13:48, Anthony PERARD wrote: > On Wed, Feb 09, 2022 at 12:26:05PM +0000, Jane Malalane wrote: >> On 08/02/2022 15:26, Roger Pau Monné wrote: >>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote: >>>> diff --git a/tools/golang/xenlight/types.gen.go >>>> b/tools/golang/xenlight/types.gen.go >>>> index b1e84d5258..5f384b767c 100644 >>>> --- a/tools/golang/xenlight/types.gen.go >>>> +++ b/tools/golang/xenlight/types.gen.go >>>> @@ -389,6 +389,10 @@ RunHotplugScripts Defbool >>>> DriverDomain Defbool >>>> Passthrough Passthrough >>>> XendSuspendEvtchnCompat Defbool >>>> +ArchX86 struct { >>>> +AssistedXapic Defbool >>>> +AssistedX2Apic Defbool >>> >>> Don't you need some indentation here? >> I hadn't realized it appeared like this here (and the same happens for >> other parts of my code as I'm seeing now) because the git output is >> correct. I will fix it. >>> >>> Also name would better be Assistedx{2}APIC IMO if possible. Having a >>> capital 'X' and lowercase 'apic' looks really strange. >> Okay. > > > This is a generated file, you can't change indentation or fields names. > It would be rebuilt automatically if you had golang installed and where > rebuilding all the tools. > > There's two ways to generate it, you could install golang and build all > the tools. Or without golang: just > `cd tools/golang/xenlight; make types.gen.go`. Both should regenerate > both "helpers.gen.go" "types.gen.go" files. > > There's an even easier way, tell the committer to regen the files when > committing :-).
Oh, yeah I forgot they were automatically generated. Right, thank you. Jane.