On 23.02.2022 19:38, Julien Grall wrote: > From: Julien Grall <jgr...@amazon.com> > > free_heap_pages() has an ASSERT() checking that node is >= 0. However > node is defined as an unsigned int. So it cannot be negative. > > Therefore remove the check as it will always be true. > > Signed-off-by: Julien Grall <jgr...@amazon.com> > > --- > > I have looked at the history. AFAICT, node has always be defined > as unsigned int. So the ASSERT() may have never been useful (?).
Commit f0738d2d3f81 introduced "node" as a local variable of type "int". Along with this commit f1c6ac275100 introduced ia64's paddr_to_nid() (backing phys_to_nid()), which was able to return -1. Hence at the time the assertion fulfilled a purpose. I should have dropped it in bd3e1195d694. Acked-by: Jan Beulich <jbeul...@suse.com> Jan
