On 09.03.2022 15:45, Jan Beulich wrote: > On 04.03.2022 18:46, Marco Solieri wrote: >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -230,6 +230,13 @@ static bool __read_mostly scrub_debug; >> #define scrub_debug false >> #endif >> >> +#ifdef CONFIG_COLORING >> +/* Minimum size required for buddy allocator to work with colored one */ >> +unsigned long buddy_required_size __read_mostly = MB(64); >> +#else >> +unsigned long buddy_required_size __read_mostly = 0; >> +#endif > > Please avoid such redundancy when possible. Here perhaps easiest > by having the value come from Kconfig. By giving that separate > option a prompt, it would even become configurable at build time.
Oh, and: Why is this not static? And without seeing what it's going to be used for it's quite hard to judge whether the initial value chosen is actually sufficient. I could imagine that this would rather want to be derived from total memory size. Jan
