Peter Maydell <peter.mayd...@linaro.org> writes: > On Mon, 14 Mar 2022 at 16:01, Markus Armbruster <arm...@redhat.com> wrote: >> >> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, >> for two reasons. One, it catches multiplication overflowing size_t. >> Two, it returns T * rather than void *, which lets the compiler catch >> more type errors. >> >> This commit only touches allocations with size arguments of the form >> sizeof(T). >> >> Patch created mechanically with: >> >> $ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \ >> --macro-file scripts/cocci-macro-file.h FILES... >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- > >> 104 files changed, 197 insertions(+), 202 deletions(-) > > I'm not going to say you must split this patch up. I'm just going to > say that I personally am not looking at it, because it's too big > for me to deal with.
As with all big but trivial Coccinelle patches, reviewing the Coccinelle script and a reasonably representative sample of its output is almost certainly a better use of reviewer time than attempting to get all the patches reviewed. They are mind-numbingly dull! For what it's worth, we've used this script several times before. Last in commit bdd81addf4.
