On 01.04.2022 14:02, George Dunlap wrote: >> On Feb 23, 2022, at 3:58 PM, Jan Beulich <jbeul...@suse.com> wrote: >> >> Rename guest_physmap_add_entry() to p2m_add_page(); make >> guest_physmap_remove_page() a trivial wrapper around p2m_remove_page(). >> This way callers can use suitable pairs of functions (previously >> violated by hvm/grant_table.c). >> >> In HVM-specific code further avoid going through the guest_physmap_*() >> layer, and instead use the two new/renamed functions directly. >> >> Ultimately the goal is to have guest_physmap_...() functions cover all >> types of guests, but p2m_...() dealing only with translated ones. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> Reviewed-by: Paul Durrant <p...@xen.org> > > Description reads much better to me — thanks!
Well - thanks to you, as iirc it is largely based on your suggestion. > Reviewed-by: George Dunlap <george.dun...@citrix.com> Thanks. Jan
