Hi Julien, On 16.05.2022 19:02, Julien Grall wrote: > +static int cpu_callback(struct notifier_block *nfb, unsigned long action, > + void *hcpu) > +{ > + unsigned long cpu = (unsigned long)hcpu; As cpu does not change in this function, shouldn't we mark it as const?
> + int rc = 0; > + > + switch ( action ) > + { > + case CPU_UP_PREPARE: > + rc = gicv3_lpi_allocate_pendtable(cpu); > + if ( rc ) > + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", %u requires unsigned int but cpu is unsigned long. FWICS this will cause a compilation error, so you should change to %lu. > + cpu); > + break; > } > > - return gicv3_lpi_set_proptable(rdist_base); > + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); > } > Cheers, Michal