On 02.06.2022 04:18, Penny Zheng wrote: >> From: Jan Beulich <jbeul...@suse.com> >> Sent: Tuesday, May 31, 2022 4:37 PM >> >> On 31.05.2022 05:12, Penny Zheng wrote: >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -151,10 +151,6 @@ >>> #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) >>> #endif >>> >>> -#ifndef PGC_staticmem >>> -#define PGC_staticmem 0 >>> -#endif >>> - >> >> Is the moving of this into the header really a necessary part of this change? >> Afaics the symbol is still only ever used in this one C file. > > Later, in commit "xen/arm: unpopulate memory when domain is static", > we will use this flag in xen/arch/arm/include/asm/mm.h
IOW you want to move this change there. Jan