On Wed, Jun 15, 2022 at 08:11:10AM +0200, Jan Beulich wrote: > On 14.06.2022 18:22, Anthony PERARD wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which > > python3 python python2 2>/dev/null) > > export PYTHON ?= $(PYTHON_INTERPRETER) > > > > export CHECKPOLICY ?= checkpolicy > > +export PERL ?= perl > > > > $(if $(filter __%, $(MAKECMDGOALS)), \ > > $(error targets prefixed with '__' are only for internal use)) > > Considering my patch yesterday that moved the exporting of CC etc, I > wonder if - at the very least for consistency - this and the neighbouring > pre-existing exports shouldn't all be moved below the inclusion of > ./Config.mk as well. After all ./config might override any of those. > (Yes, the ones here don't prevent such overriding, but only as long as > there aren't any further make quirks.)
Sounds good, we can move CHECKPOLICY and PERL, but there's a problem with PYTHON. Config.mk define a different value for PYTHON, so the one in xen/Makefile needs to be set before including ./Config.mk. Thanks, -- Anthony PERARD
