On 29.06.2022 13:09, Jan Beulich wrote: > On 29.06.2022 12:43, Anthony PERARD wrote: >> On Thu, Jun 23, 2022 at 09:23:27AM +0200, Jan Beulich wrote: >>> On 13.04.2022 13:21, Jane Malalane wrote: >>>> Jane Malalane (2): >>>> xen+tools: Report Interrupt Controller Virtualization capabilities on >>>> x86 >>>> x86/xen: Allow per-domain usage of hardware virtualized APIC >>>> >>>> docs/man/xl.cfg.5.pod.in | 15 ++++++++++++++ >>>> docs/man/xl.conf.5.pod.in | 12 +++++++++++ >>>> tools/golang/xenlight/helpers.gen.go | 16 ++++++++++++++ >>>> tools/golang/xenlight/types.gen.go | 4 ++++ >>>> tools/include/libxl.h | 14 +++++++++++++ >>>> tools/libs/light/libxl.c | 3 +++ >>>> tools/libs/light/libxl_arch.h | 9 ++++++-- >>>> tools/libs/light/libxl_arm.c | 14 ++++++++++--- >>>> tools/libs/light/libxl_create.c | 22 ++++++++++++-------- >>>> tools/libs/light/libxl_types.idl | 4 ++++ >>>> tools/libs/light/libxl_x86.c | 39 >>>> +++++++++++++++++++++++++++++++++-- >>>> tools/ocaml/libs/xc/xenctrl.ml | 7 +++++++ >>>> tools/ocaml/libs/xc/xenctrl.mli | 7 +++++++ >>>> tools/ocaml/libs/xc/xenctrl_stubs.c | 17 ++++++++++++--- >>>> tools/xl/xl.c | 8 +++++++ >>>> tools/xl/xl.h | 2 ++ >>>> tools/xl/xl_info.c | 6 ++++-- >>>> tools/xl/xl_parse.c | 19 +++++++++++++++++ >>>> xen/arch/x86/domain.c | 29 +++++++++++++++++++++++++- >>>> xen/arch/x86/hvm/hvm.c | 3 +++ >>>> xen/arch/x86/hvm/vmx/vmcs.c | 11 ++++++++++ >>>> xen/arch/x86/hvm/vmx/vmx.c | 13 ++++-------- >>>> xen/arch/x86/include/asm/hvm/domain.h | 6 ++++++ >>>> xen/arch/x86/include/asm/hvm/hvm.h | 10 +++++++++ >>>> xen/arch/x86/sysctl.c | 4 ++++ >>>> xen/arch/x86/traps.c | 5 +++-- >>>> xen/include/public/arch-x86/xen.h | 5 +++++ >>>> xen/include/public/sysctl.h | 11 +++++++++- >>>> 28 files changed, 281 insertions(+), 34 deletions(-) >>>> >>> >>> Just FYI: It's been over two months that v10 has been pending. There >>> are still missing acks. You may want to ping the respective maintainers >>> for this to make progress. >> >> Are you looking for a ack for the "docs/man" changes? If so, I guess >> I'll have to make it more explicit next time that a review for "tools" >> also mean review of the changes in their respective man pages. > > No, the docs changes (being clearly tools docs) are fine. > >> Or are you looking for a ack for the "golang" changes? Those changes are >> automatically generated by a tool already in our repository. > > Indeed it's Go (where I think an ack is still required, no matter > if the changes are generated ones [which I wasn't even aware of, I > have to confess]) and ... > >> Or is it an "ocaml" ack for the first patch? Unfortunately, the >> maintainers haven't been CCed, I guess that could be an issue. > > ... OCaml which I was after.
Oh and actually for at least patch 2 also VMX. For patch 1 I've sent a separate reply to the resent v10. Jan
