> On 20 Jul 2022, at 19:44, Julien Grall <jul...@xen.org> wrote: > > From: Julien Grall <jgr...@amazon.com> > > At the moment, the domheap mappings initialization is done separately for > the boot CPU and secondary CPUs. The main difference is for the former > the pages are part of Xen binary whilst for the latter they are > dynamically allocated. > > It would be good to have a single helper so it is easier to rework > on the domheap is initialized. > > For CPU0, we still need to use pre-allocated pages because the > allocators may use domain_map_page(), so we need to have the domheap > area ready first. But we can still delay the initialization to setup_mm(). > > Introduce a new helper init_domheap_mappings() that will be called > from setup_mm() for the boot CPU and from init_secondary_pagetables() > for secondary CPUs. > > Signed-off-by: Julien Grall <jgr...@amazon.com> >
Hi Julien, With Bertrand's comment addressed: Reviewed-by: Luca Fancellu <luca.fance...@arm.com> I’ve also tested with fvp using aarch32 configuration starting Dom0 and few guests and everything works. Tested-by: Luca Fancellu <luca.fance...@arm.com> Cheers, Luca