On 09.08.2022 09:53, Penny Zheng wrote: >> -----Original Message----- >> From: Xen-devel <xen-devel-boun...@lists.xenproject.org> On Behalf Of Jan >> Beulich >> Sent: Monday, July 25, 2022 11:44 PM >> >> On 20.07.2022 07:46, Penny Zheng wrote: >>> When a static domain populates memory through populate_physmap at >>> runtime, it shall retrieve reserved pages from resv_page_list to make >>> sure that guest RAM is still restricted in statically configured memory >> regions. >>> This commit also introduces a new helper acquire_reserved_page to make >> it work. >>> >>> Signed-off-by: Penny Zheng <penny.zh...@arm.com> >>> --- >>> v9 changes: >>> - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page >>> - Add free_staticmem_pages to undo prepare_staticmem_pages when >>> assign_domstatic_pages fails >> >> May I suggest to re-consider naming of the various functions? Undoing what >> "prepare" did by "free" is, well, counterintuitive. >> > > How about change the name "prepare_staticmem_pages" to > "allocate_staticmem_pages"?
Perhaps - if what the function does really resembles allocation in some way. So far I wasn't really certain in that regard, and hence I was wondering whether "prepare" doesn't better describe what it does, but then its inverse also doesn't really "free" anything. Jan
