On 15.08.2022 10:17, Julien Grall wrote: > On 15/08/2022 07:43, Jan Beulich wrote: >> On 12.08.2022 21:24, Julien Grall wrote: >>> From: Julien Grall <jgr...@amazon.com> >>> >>> At the moment, the strings are in text right after each use because >>> the instruction 'adr' has specific requirement on the location >>> and the compiler will forbid cross section label. >>> >>> The macro 'adr_l' was recently reworked so the caller doesn't need >>> to know whether the MMU is on. This makes it easier to use where >>> instructions can be run in both context. >>> >>> This also means that the strings don't need to be part of .text >>> anymore. So move them to .rodata.str. >> >> Wouldn't they better live somewhere in .init* ? > > PRINT() is also used in path for secondary bring-up. So this could be > used after .init (even though today CPU hotplug doesn't work on Arm).
Then the term "earlyprintk" looks to be misleading? > Furthermore, PRINT() is only used when earlyprintk is enabled. This > should only be used in a development environment (gated by > CONFIG_DEBUG). So I think it is better to keep all the strings in > .rodata.str rather than trying to distinguish whether the caller will > happen only during init on boot. Fair enough. Jan
