On 24/08/2022 11:35, Jan Beulich wrote: > On 24.08.2022 12:22, Juergen Gross wrote: >> Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production >> builds a warning seems to be appropriate when hitting one. > I disagree, for two reasons: This violates the implication of NDEBUG > meaning ASSERT() and friends expand to no actual code.
I agree. ASSERT() and friends should no code in !DEBUG builds. Furthermore, if an ASSERT_UNREACHALBE() is proving to be problematic even at runtime, then it's not the correct construct in the first place. ~Andrew
