On 25.08.2022 20:09, Stefano Stabellini wrote: > But first, let's confirm whether this change: > > > #define dt_for_each_property_node(dn, pp) \ > - for ( pp = dn->properties; pp != NULL; pp = pp->next ) > + for ( pp = (dn)->properties; pp != NULL; pp = (pp)->next ) > > > is sufficient to make the violation go away in Eclair or cppcheck. I am > assuming it is not sufficient, but let's confirm.
Well, even if for the lhs of assignments there was an exception, this still wouldn't be sufficient. The minimum needed is #define dt_for_each_property_node(dn, pp) \ for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) Jan