Hi Michal, On Wed, Aug 24, 2022 at 10:23 AM Michal Orzel <[email protected]> wrote: > > Hi Jens, > > On 18/08/2022 12:55, Jens Wiklander wrote: > > Moves the two helper functions regpair_to_uint64() and > > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm > > specific regs.h. > > > Would be good to add a justification that these helpers will be needed by > subsequent patches. > Also I can see that you make use of them only in the last patch so it would > be natural to > move this patch right before the one making use of these helpers.
I put it at the beginning of the patches to get prerequisites in place before the tricky stuff, but I'll move it since that's preferred. I'll add update the commit message. > > > Signed-off-by: Jens Wiklander <[email protected]> > > As for the patch itself: > Reviewed-by: Michal Orzel <[email protected]> Thanks, Jens > > ~Michal
