Hi, > On 1 Sep 2022, at 02:03, Henry Wang <henry.w...@arm.com> wrote: > > Hi Arm maintainers, > >> -----Original Message----- >> Hi Henry, >> >> On 30/08/2022 08:11, Henry Wang wrote: >>> >>> Hi Michal, >>> >>> Sorry about the late reply - I had a couple of days off. Thank you very >>> much for the review! I will add my reply and answer some of your >>> questions below. >>> >>>> -----Original Message----- >>>> From: Michal Orzel <michal.or...@amd.com> >>>> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot >> and >>>> heap allocator >>>> >>>>> This commit firstly adds a global variable `reserved_heap`. >>>>> This newly introduced global variable is set at the device tree >>>>> parsing time if the reserved heap ranges are defined in the device >>>>> tree chosen node. >>>>> >>>> Did you consider putting reserved_heap into bootinfo structure? >>> >>> Actually I did, but I saw current bootinfo only contains some structs so >>> I was not sure if this is the preferred way, but since you are raising this >>> question, I will follow this method in v2. >> >> This is what I think would be better but maintainers will have a decisive >> vote. > > I think this is the only uncertain comment that I received during the latest > review of this series. I agree that Michal is making a good point (Thanks!) > but we > are curious about what maintainers think. Could you please kindly share your > opinion on the more preferred approach? I will do that in v2. Thanks very > much!
I think it does make sense to put this in bootinfo. Cheers Bertrand
