Hi Jens, On Thu, Aug 18, 2022 at 12:55:55PM +0200, Jens Wiklander wrote: > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de093914..a985609861c7 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + config->arch.ffa_enabled = > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled);
There seems to be missing a call to libxl_defbool_setdefault() before this. This could result in an abort when creating a guest for Arm. A call to libxl_defbool_setdefault() probably want to be done in libxl__arch_domain_build_info_setdefault() in libxl_arm.c. > return 0; > } > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index b98c0de378b6..e0e99ed8d2b1 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2746,6 +2746,9 @@ skip_usbdev: > exit(-ERROR_FAIL); > } > } > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); This should be done in libxl (as pointed out above) instead of xl. > + xlu_cfg_get_defbool(config, "ffa_enabled", > + &b_info->arch_arm.ffa_enabled, 0); > > parse_vkb_list(config, d_config); > Thanks, -- Anthony PERARD
