On 26.09.22 23:11, Borislav Petkov wrote:
On Thu, Sep 08, 2022 at 10:49:12AM +0200, Juergen Gross wrote:-void set_mtrr_aps_delayed_init(void) -{ - if (!cache_generic) - return; - - mtrr_aps_delayed_init = true; -} -Except that you've removed the accessors and made that bool global. Which is less pretty than it was before...
The accessor would now only need to set the bool, while it had at least some logic before. TBH I don't see the point of having an accessor which is just setting a variable to "true". But if you like it better, I can keep it. Another possibility would be to move the arch_thaw_secondary_cpus_begin() and arch_thaw_secondary_cpus_end() functions to cacheinfo.c, resulting in only a single place outside of cacheinfo.c setting the variable (in theory the arch_thaw_secondary_cpus_*() functions could just be redefined to the accessor and cache_aps_init(), but this would be rather hacky IMO). Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature