Hi Bertrand,
> -----Original Message-----
> From: Bertrand Marquis <bertrand.marq...@arm.com>
> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>
> Hi,
>
> > On 21 Oct 2022, at 15:40, Henry Wang <henry.w...@arm.com> wrote:
> >
> > (+ Arm maintainers)
> >
> > Hi Oleksandr,
> >
> >> -----Original Message-----
> >> From: Oleksandr <olekst...@gmail.com>
> >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
> >> Hello all.
> >> On 19.07.22 13:40, Jan Beulich wrote:
> >>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
> >>>> Jan Beulich <jbeul...@suse.com> writes:
> >>>>
> >>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
> >>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
> >>>>>> iounmap(), but not added corresponding include.
> >>>>>>
> >>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> >>>>> I don't think there's any active issue with the "missing" include:
> >>>>> That's only a problem once Arm has vPCI code enabled? In which
> >>>>> case I don't think a Fixes: tag is warranted.
> >>>> Fair enough. May I ask committer to drop this tag?
> >>> I had taken respective note already, in case I end up committing this.
> >>> But this is the last patch of the series, so I can only guess whether
> >>> it might be okay to go in ahead of the other three patches.
> >>>
> >>> Jan
> >>
> >>
> >> I am wondering, where this patch could be 4.17 material?
> >>
> >> The patch series seem to get stuck, but the current patch just adds a
> >> missing include to fix a build on Arm, so it is completely independent.
> >> I agree, there is no issue with the current code base as vPCI is
> >> disabled on Arm, so nothing to fix right now. But as PCI
> >> passthrough/vPCI on Arm is in the development stage, the developers
> >> enable that support in their builds. I think the risk is rather low than
> >> high.
> >
> > It seems reasonable to me, but I am curious about what Arm maintainers
> > and PCI maintainers think. From the history discussion in this thread I
> > think it is pretty safe to include this in 4.17. Thanks for the ping.
>
> I think this can safely go in for 4.17.
>
> Cheers
> Bertrand
Thanks for the feedback :) Feel free to add my:
Release-acked-by: Henry Wang <henry.w...@arm.com>
Kind regards,
Henry
>
> >
> > Kind regards,
> > Henry
> >
> >
> >>
> >>
> >>
> >> --
> >> Regards,
> >>
> >> Oleksandr Tyshchenko
>
