> On 16 Dec 2022, at 18:25, Edwin Török <edvin.to...@citrix.com> wrote: > > From: Edwin Török <edwin.to...@cloud.com> > > Various OCaml fixes, some of which got Acked already. > > Edwin Török (11): > tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper > tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order > CODING_STYLE(tools/ocaml): add 'make format' and remove tabs > tools/ocaml: run "make format" > CODING-STYLE(tools/ocaml): add .editorconfig to clarify indentation > uses spaces > tools/ocaml: add .clang-format > fixup! tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free > tools/ocaml/libs/mmap: mark mmap/munmap as blocking and raise > Unix_error on failure > tools/ocaml/libs/xb: check for unmapped ring before accessing it > tools/ocaml/xenstored: validate config file before live update > tools/ocaml/libs/xb: drop Xs_ring.write
I’m going to Ack this whole sale and provide individual comments. Acked-by: Christian Lindig <christian.lin...@citrix.com>