On 21.12.2022 12:09, Xenia Ragiadakou wrote: > > On 12/21/22 12:13, Jan Beulich wrote: >> On 19.12.2022 07:34, Xenia Ragiadakou wrote: >>> @@ -774,6 +779,16 @@ static inline void hvm_set_nonreg_state(struct vcpu *v, >>> alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs); >>> } >>> >>> +static inline int hvm_pi_update_irte(const struct vcpu *v, >>> + const struct pirq *pirq, uint8_t gvec) >> >> Why "int" as return type when both call sites ignore the return value? > > Because the original function returned int.
Hmm, indeed - looking more closely there can actually be errors, and those shouldn't really be ignored in all cases. At the very least an assertion would seem on order. > I 'm not sure though why the returned value is ignored. Kevin, thoughts? Jan
