Wei,

On 2/21/18 3:46 PM, Wei Liu wrote:
It is never used and it is getting in the way of cleaning up.

The only callsite of guest_iommu_add_ppr_log has no effect because
guest iommu is not initialised.

Signed-off-by: Wei Liu<wei.l...@citrix.com>
---
Cc: Suravee Suthikulpanit<suravee.suthikulpa...@amd.com>
---
  xen/drivers/passthrough/x86/amd/Makefile      |   1 -
  xen/drivers/passthrough/x86/amd/iommu_guest.c | 927 --------------------------
  xen/drivers/passthrough/x86/amd/iommu_init.c  |  21 +-
  xen/include/asm-x86/amd-iommu.h               |  51 --
  xen/include/asm-x86/hvm/svm/amd-iommu-proto.h |   8 -
  xen/include/asm-x86/iommu.h                   |   1 -
  6 files changed, 6 insertions(+), 1003 deletions(-)
  delete mode 100644 xen/drivers/passthrough/x86/amd/iommu_guest.c

Would it be too much trouble if we keep this code for now. There is a plan to 
support
IOMMU in guest in the near future. This could be clean up at that point if no 
longer
needed.

Thanks,
Suravee

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to