On 15/02/2023 11:27 am, Jan Beulich wrote: > Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to > 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant > with the PAE_MODE ELF note anyway. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -934,12 +934,8 @@ void xen_enable_syscall(void) > > static void __init xen_pvmmu_arch_setup(void) > { > - HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments); > HYPERVISOR_vm_assist(VMASST_CMD_enable, > VMASST_TYPE_writable_pagetables);
I find it disappointing that a PV guest which states a hard dependency on writeable pagetables in its elfnotes doesn't have this activated automatically. The PV API/ABI truly is an undesigned mess. ~Andrew