On 17.02.2023 00:17, Andrew Cooper wrote: > On 16/02/2023 11:02 pm, Andrew Cooper wrote: >> On 16/02/2023 10:44 pm, Andrew Cooper wrote: >>> Clang-15 (as seen in the FreeBSD 14 tests) complains: >>> >>> arch/x86/time.c:1364:20: error: a function declaration without a >>> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] >>> s_time_t get_s_time() >>> ^ >>> void >>> >>> The error message is a bit confusing but appears to new as part of >>> -Wdeprecated-non-prototype which is part of supporting C2x which formally >>> removes K&R syntax. >>> >>> Either way, fix the offending functions. >>> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >>> --- >>> CC: Jan Beulich <jbeul...@suse.com> >>> CC: Roger Pau Monné <roger....@citrix.com> >>> CC: Wei Liu <w...@xen.org> >>> >>> These are all the examples found in a default build of Xen. I'm still >>> finding >>> toolstack violations. >> Apparently not. int cf_check vmx_cpu_up() too. > > Ok, finally got a clean Clang-15 build. I've folded this hunk into the > patch: > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index 09edbd23b399..e1c268789e7e 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -781,7 +781,7 @@ static int _vmx_cpu_up(bool bsp) > return 0; > } > > -int cf_check vmx_cpu_up() > +int cf_check vmx_cpu_up(void) > { > return _vmx_cpu_up(false); > } > > > but am not intending to send a v2 given how trivial it is.
Sure. Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan