On 24.02.2023 15:48, Oleksii Kurochko wrote:
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void)
> early_printk("WARN is most likely working\n");
> }
>
> +static void __init init_bss(void)
> +{
> + extern char __bss_start;
> + extern char __bss_end;
Better use [] and then perhaps omit the & operators further down.
However, I thought we have a compiler warning option in use which
precludes extern declarations which aren't at file scope. Even if
I'm misremembering, perhaps better to move them.
> + char *bss = &__bss_start;
> +
> + while ( bss < &__bss_end ) {
> + *bss = 0;
> + bss++;
> + }
> +}
If you're sure you can defer this until being in C code, why not use
memset()?
Jan
