On 25.02.2023 17:42, Julien Grall wrote: > On 24/02/2023 11:31, Oleksii Kurochko wrote: >> --- /dev/null >> +++ b/xen/common/bug.c >> @@ -0,0 +1,109 @@ >> +#include <xen/bug.h> >> +#include <xen/debugger.h> >> +#include <xen/errno.h> >> +#include <xen/kernel.h> >> +#include <xen/livepatch.h> > +#include <xen/string.h> >> +#include <xen/types.h> >> +#include <xen/virtual_region.h> >> + >> +#include <asm/processor.h> >> + >> +/* Set default value for TRAP_invalid_op as it is defined only for X86 now >> */ >> +#ifndef TRAP_invalid_op >> +#define TRAP_invalid_op 0 >> +#endif > > It feels to me that this value should be defined in the else part in > xen/debugger.h.
I guess with [1] it won't be as straightforward anymore ... Jan [1] https://lists.xen.org/archives/html/xen-devel/2023-02/msg01026.html
