On 24.02.2023 19:50, Xenia Ragiadakou wrote: > --- /dev/null > +++ b/xen/arch/x86/hvm/vmx/pi.h > @@ -0,0 +1,78 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * pi.h: VMX Posted Interrupts > + * > + * Copyright (c) 2004, Intel Corporation. > + */ > + > +#ifndef __X86_HVM_VMX_PI_PRIV_H__ > +#define __X86_HVM_VMX_PI_PRIV_H__
I can see that you need something to disambiguate the two vmx.h. But here you don't need the PRIV infix, do you? Even in the private vmx.h I'd like to ask to consider e.g. __VMX_H__ as the guard (and then __PI_H__ here), rather than one which doesn't really match the filename. Jan
