On 02/03/2023 15:34, David Woodhouse wrote:
From: David Woodhouse <d...@amazon.co.uk>In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest to be recreated? Will defer to Paul for that.
Yes. Assuming backends have properly implemented save/restore code then they should be able to re-create their xenstore content. Also, it's generally convenient for them to start back in 'InitWait' state the drive their state machine back to 'Connected' so that grant refs can be mapped, event channels bound etc. along the way.
Signed-off-by: David Woodhouse <d...@amazon.co.uk> --- hw/i386/kvm/xen_xenstore.c | 25 +- hw/i386/kvm/xenstore_impl.c | 574 +++++++++++++++++++++++++++++++++++- hw/i386/kvm/xenstore_impl.h | 5 + tests/unit/test-xs-node.c | 236 ++++++++++++++- 4 files changed, 824 insertions(+), 16 deletions(-)
The code LGTM though; just need to limit the saved tree to '/local/domain/<domid>'
Paul
