On 13.03.2023 08:26, Christian König wrote:
> Am 13.03.23 um 08:23 schrieb Christian König:
>> Am 12.03.23 um 08:54 schrieb Huang Rui:
>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -392,7 +392,7 @@ static void cf_check bar_write(
>>> * Xen only cares whether the BAR is mapped into the p2m, so
>>> allow BAR
>>> * writes as long as the BAR is not mapped into the p2m.
>>> */
>>> - if ( bar->enabled )
>>> + if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) &
>>> PCI_COMMAND_MEMORY )
>>
>> Checkpath.pl gives here:
>>
>> ERROR: space prohibited after that open parenthesis '('
>> #115: FILE: xen/drivers/vpci/header.c:395:
>> + if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
>
> But I should probably mention that I'm not 100% sure if this code base
> uses kernel coding style!
It doesn't - see ./CODING_STYLE.
Jan
