On 15.03.2023 19:51, Andrew Cooper wrote: > riscv64-linux-gnu-gcc -MMD -MP -MF arch/riscv/.early_printk.o.d -DBUILD_ID > -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes > -Wdeclaration-after-statement -Wno-unused-but-set-variable > -Wno-unused-local-typedefs -O1 -fno-omit-frame-pointer -nostdinc > -fno-builtin -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla > -pipe -D__XEN__ -include ./include/xen/config.h -Wa,--strip-local-absolute -g > -mabi=lp64 -I./include -I./arch/riscv/include -march=rv64gc -mstrict-align > -mcmodel=medany -c arch/riscv/early_printk.c -o arch/riscv/early_printk.o > arch/riscv/early_printk.c:18:2: error: #error "early_*() can be called from > head.S with MMU-off" > 18 | #error "early_*() can be called from head.S with MMU-off" > | ^~~~~ > > $ riscv64-linux-gnu-gcc --version > riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110 > > The binary is otherwise correct, so remove the incorrect check. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
I'm with Julien here - this needs further explaining: The compiler (even 8.2) clearly provides this definition with the given set of command line options, as supported by trying it out om godbolt. So there must be more to this - could be a bad patch in Debian's build, could be some odd interaction of command line options which for whatever reason only triggers with certain builds, or about anything else. Jan
