Hi Jan, > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Subject: Re: [PATCH v3 02/17] xen/arm: implement helpers to get and update > NUMA status > > --- > > v2 -> v3: > > 1. Rename the first entry of enum dt_numa_status as DT_NUMA_DEFAULT. > > 2. Make enum dt_numa_status device_tree_numa as __ro_after_init and > > assign it explicitly to DT_NUMA_DEFAULT. > > 3. Update the year in copyright to 2023. > > 4. Don't move the x86 numa_disabled() and make Arm's numa_disabled() > > a static inline function for !CONFIG_NUMA. > > v1 -> v2: > > 1. Use arch_numa_disabled to replace numa_enable_with_firmware. > > 2. Introduce enumerations for device tree numa status. > > 3. Use common numa_disabled, drop Arm version numa_disabled. > > 4. Introduce arch_numa_setup for Arm. > > 5. Rename bad_srat to numa_bad. > > 6. Add numa_enable_with_firmware helper. > > 7. Add numa_disabled helper. > > 8. Refine commit message. > > --- > > xen/arch/arm/include/asm/numa.h | 17 +++++++++++ > > xen/arch/arm/numa.c | 50 +++++++++++++++++++++++++++++++++ > > 2 files changed, 67 insertions(+) > > create mode 100644 xen/arch/arm/numa.c > > While I was Cc-ed on this one, neither the diffstat nor any possible remarks > make clear whether anything is expected of me here.
Sorry for the confusion. I also thought of this when sending the email but eventually decided to add you in the Cc as you made some correct and helpful comments in v2 [1], so I think it is a good manner to add you so that you would know all your (correct) remarks are addressed. Thanks for reviewing the series. [1] https://patchwork.kernel.org/project/xen-devel/patch/20230110084930.1095203-3-wei.c...@arm.com/ Kind regards, Henry > > Jan
