Hi Ayan,
On 28 Apr 2023, at 2:30 pm, Ayan Kumar Halder <ayank...@amd.com> wrote:
Hi Rahul,
On 28/04/2023 13:36, Rahul Singh wrote:
CAUTION: This message has originated from an External Source. Please use proper
judgment and caution when opening attachments, clicking links, or responding to
this email.
Xen 4.17 supports the creation of static evtchns. To allow user space
application to bind static evtchns introduce new ioctl
"IOCTL_EVTCHN_BIND_STATIC". Existing IOCTL doing more than binding
that’s why we need to introduce the new IOCTL to only bind the static
event channels.
Also, static evtchns to be available for use during the lifetime of the
guest. When the application exits, __unbind_from_irq() end up
being called from release() fop because of that static evtchns are
getting closed. To avoid closing the static event channel, add the new
bool variable "is_static" in "struct irq_info" to mark the event channel
static when creating the event channel to avoid closing the static
evtchn.
Signed-off-by: Rahul Singh <rahul.si...@arm.com>
---
drivers/xen/events/events_base.c | 7 +++++--
drivers/xen/evtchn.c | 22 +++++++++++++++++-----
include/uapi/xen/evtchn.h | 9 +++++++++
include/xen/events.h | 2 +-
4 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index c7715f8bd452..31f2d3634ad5 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -112,6 +112,7 @@ struct irq_info {
unsigned int irq_epoch; /* If eoi_cpu valid: irq_epoch of event */
u64 eoi_time; /* Time in jiffies when to EOI. */
raw_spinlock_t lock;
+ u8 is_static; /* Is event channel static */
I think we should avoid u8/u16/u32 and instead use uint8_t/uint16_t/uint32_t.
However in this case, you can use bool.
Make sense. I will change to bool in next patch.
Regards,
Rahul
