Henry Wang <henry.w...@arm.com>于2023年5月4日 周四12:23写道：
> Hi Vikram, > > > -----Original Message----- > > Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add > > device_tree_find_node_by_path() to find nodes in device tree > > > > Add device_tree_find_node_by_path() to find a matching node with path for > > a > > dt_device_node. > > > > Reason behind this function: > > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > > device_tree_flattened) is created and updated with overlay nodes. > This > > updated fdt is further unflattened to a dt_host_new. Next, we need > to find > > the overlay nodes in dt_host_new, find the overlay node's parent in > dt_host > > and add the nodes as child under their parent in the dt_host. Thus > we need > > this function to search for node in different unflattened device > trees. > > > > Also, make dt_find_node_by_path() static inline. > > > > Signed-off-by: Vikram Garhwal <vikram.garh...@amd.com> > > --- > > xen/common/device_tree.c | 5 +++-- > > xen/include/xen/device_tree.h | 17 +++++++++++++++-- > > 2 files changed, 18 insertions(+), 4 deletions(-) > > > > [...] > > > /** > > - * dt_find_node_by_path - Find a node matching a full DT path > > + * device_tree_find_node_by_path - Generic function to find a node > > matching the > > + * full DT path for any given unflatten device tree > > + * @dt_node: The device tree to search > > I noticed that you missed Michal's comment here about renaming the > "dt_node" here to "dt" to match below function prototype... > > > * @path: The full path to match > > * > > * Returns a node pointer. > > */ > > -struct dt_device_node *dt_find_node_by_path(const char *path); > > +struct dt_device_node *device_tree_find_node_by_path(struct > > dt_device_node *dt, > > ...here. I personally agree with Michal so I think please fix the comment > to keep consistency. > > The rest of the patch looks good to me, so as long as you fixed this, you > can have my: > > Reviewed-by: Henry Wang <henry.w...@arm.com> > > Kind regards, > Henry > > >
